mmctl: Review unarchiveChannelsCmdF function to return an error in case of a failure

[mattermod]

In the course of Hacktober 2022, we would like to review the return codes of the mmctl subcommands. It turns out that we have some subcommands that return 0 (successful return code) even if they fail. This is not a good practice and we should fix it. In this context, we would like to review unarchiveChannelsCmdF function and tailor a way to return a non-zero return code if the function fails. To be able to return a non-zero return code, it should be enough to return the error value from the handler. This effort should also include updating the test files for the command handler. The specific handler can be found in the file: https://github.com/mattermost/mmctl/blob/master/commands/channel.go

PS: You don't need to check errors for parsing the flags. The goal of this ticket is to pass error to the root handler so that we can have a non zero return code. If there are multiple errors can occur in a loop, please consider using multiError.Error to append the errors and return the error after the loop.

---

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-47348

[arcbjorn]

Hi! I'd like to work on it 🙂

[kurayami07734]

I want to work on this

[kurayami07734]

When does it not return error even if its failing?

[lukas-mar]

hi, is this isssue still relevant? I would like to work on it

[hanzei]

@lukas-mar Thanks for working on the ticket @lukas-mar 👍 Please let me know if you have any questions.

[hanzei]

@lukas-mar Do you still want to work on the ticket?

[ezekielchow]

Can I pick this up?

[hanzei]

Sure think @ezekielchow 👍