Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate /enterprise/group_mentions e2e tests to TypeScript #21323

Open
mattermod opened this issue Oct 7, 2022 · 2 comments
Open

Migrate /enterprise/group_mentions e2e tests to TypeScript #21323

mattermod opened this issue Oct 7, 2022 · 2 comments
Assignees
Labels
Hacktoberfest Help Wanted Community help wanted

Comments

@mattermod
Copy link
Contributor

mattermod commented Oct 7, 2022

Converting following spec files under /integration/enterprise/group_mentions to Typescript

  1. group_mentions_permissions_spec.js
  2. group_mentions_system_messages_spec.js
  3. group_mentions_posts_spec.js

Below is a checklist of items you should be doing to migrate:

  1. Rename the files to their associated TypeScript extensions (ie. js to ts)
  2. Move over all the types from the declaration (d.ts) files into the matching typescript file, and delete the declaration file (see Support Migration PR link below for reference )

  1. Fix any errors generated by the TypeScript compiler.
  • Navigate to /e2e/cypress and run npm run check-types to display any errors.
  1. Run

/e2e-run from PR and make sure all migrated and existing tests are passed. Automation results can be seen here Automation Dashboard

Note:

  • Please update types in the declaration files (d.ts) if they are out of date or mismatch with actual usage.
  • Please migrate support files to typescript if the new typescript files depend on them (you will see compilation errors if this is the case)

References

📗 Suport Files Migration Reference

Support Migration PR

📘 Spec File Migration Reference

account_settings/profile tests migration PR


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-47304

@arcbjorn
Copy link

arcbjorn commented Oct 8, 2022

Hi!
I'd love to work on this issue! 🙂

@michelengelen
Copy link
Contributor

Hi @arcbjorn I just assigned this to you. If you need any help feel free to ping me.

@furqanmlk furqanmlk changed the title Migrate /enterprise/group_mentions tests to TypeScript Migrate /enterprise/group_mentions e2e tests to TypeScript Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Help Wanted Community help wanted
Projects
None yet
Development

No branches or pull requests

4 participants