Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for APNG (Animated PNG) image format #24088

Open
mattermod opened this issue Jul 20, 2023 · 13 comments · May be fixed by #25773
Open

Add support for APNG (Animated PNG) image format #24088

mattermod opened this issue Jul 20, 2023 · 13 comments · May be fixed by #25773
Assignees
Labels
Difficulty/2:Medium Medium ticket Enhancement New feature or request Help Wanted Community help wanted Tech/ReactJS Web app

Comments

@mattermod
Copy link
Contributor

In the web application, we currently have support for displaying animated GIFs. Now, we need to add similar functionality to support animated PNGs as well.

Environment: Web

Reproduction Steps:

  1. Attach the provided animated PNG file.
  2. You can use sample animated PNG images from https://en.wikipedia.org/wiki/APNG .
  3. Note that the attached image does not display animation in the post.
  4. However, if you download the attachment, you will be able to view the original animated image in your system.

Expected:

  • Instead of showing a still "preview" image, we want to display the original animated file, just like we do for animated GIFs.

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-53284

@mattermod mattermod added Help Wanted Community help wanted Up For Grabs labels Jul 20, 2023
@marianunez marianunez added the Tech/ReactJS Web app label Jul 22, 2023
@M-ZubairAhmed M-ZubairAhmed added Difficulty/2:Medium Medium ticket kind/feature Categorizes issue or PR as related to a new feature. Enhancement New feature or request and removed Enhancement New feature or request labels Jul 23, 2023
@olalekanteeblaze
Copy link

Can I pick this up? @marianunez @M-ZubairAhmed

@marianunez
Copy link
Member

Can I pick this up?

Yes! I'll assign it to you and let us know if you have any questions

@amyblais amyblais added Enhancement New feature or request and removed kind/feature Categorizes issue or PR as related to a new feature. labels Aug 4, 2023
@larkox
Copy link
Contributor

larkox commented Aug 8, 2023

@olalekanteeblaze Have you made any progress on this?

@abhinav700
Copy link
Contributor

@amyblais can I pick this issue if no one is working on it?

@larkox
Copy link
Contributor

larkox commented Sep 26, 2023

Since @olalekanteeblaze hasn't answered in a long while, I will assign it to you.

@abhinav700
Copy link
Contributor

@larkox Thanks. Will begin working on it.

@marianunez
Copy link
Member

@abhinav700 just wanted to check in and see if you have any questions about this issue?

@abhinav700
Copy link
Contributor

@marianunez I am not working on this issue anymore.(sorry for not updating, was busy with something)

I have switched to a project which is more suitable for my current skillset.

@Vinecreeper888
Copy link
Contributor

Hi, can I work on this?

@marianunez
Copy link
Member

All yours @Vinecreeper888 👍

@Vinecreeper888
Copy link
Contributor

Vinecreeper888 commented Dec 18, 2023

Edit: I am able to show the animation in preview now. But I have a doubt. When I click on the send button, the same animation is not rendered in the chat. Should I change this as well?

@marianunez, I have been experimenting with few things but not able to find a solution. Have tried a bunch of approaches still not able to render the animation in preview. Any suggestions?

@hmhealey
Copy link
Member

Do you perhaps need to have the server set FileInfo.HasPreviewImage to false? That's what the server uses for animated gifs to signal to the client that it should load the actual animated image instead of using the static preview image

@Vinecreeper888
Copy link
Contributor

@hmhealey Yeah, i guess, but I am not sure if changing it to false has an impact in other places or if it has a performance impact. I can give it a try. Let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/2:Medium Medium ticket Enhancement New feature or request Help Wanted Community help wanted Tech/ReactJS Web app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants