Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ./components/post_view/post_image/post_image.tsx from Class Component to Function Component #26209

Closed
larkox opened this issue Feb 13, 2024 · 6 comments · Fixed by #26395
Assignees
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/TypeScript

Comments

@larkox
Copy link
Contributor

larkox commented Feb 13, 2024

We want to move most of our codebase from Class Components to Function Components. This decision is based on React recommendations.

The task is to update the component to be a functional component, without any difference in functionality. Also, all related tests that fail may need refactoring.

Here are a few examples of the required changes:
#24187
#24210
#24183
#24181

If the tests do not work because they rely on the behavior of Class Components they also have to be migrated to functionaly test the same behavior. We prefer the use of react-testing-library for new tests, but it is not required.

When submitting the PR, please make sure to identify where and when the component shows, for QA to properly test the changes.


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA LINK: MM-56847

@larkox larkox added Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/TypeScript Up For Grabs labels Feb 13, 2024
@andriumm
Copy link
Contributor

Hi @larkox! I'd like to take this 😸 (Is my first contribution to open source)

@larkox
Copy link
Contributor Author

larkox commented Feb 14, 2024

@andriumm All yours, and welcome to open source 😄

@devharipragaz007
Copy link

@andriumm are you still working on this issue?

@andriumm
Copy link
Contributor

andriumm commented Mar 5, 2024

hi @devharipragaz007! Yes! I'm sorry, I didn't have time. But I'll do it this week for sure.

@devharipragaz007
Copy link

@andriumm if you want, I'll take this issue and will start working.

@andriumm
Copy link
Contributor

andriumm commented Mar 5, 2024

Hi! i'm working on that yes, If I can't make it, I'll let you know. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/TypeScript
Projects
None yet
3 participants