Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The HTML tag always has lang="en" even if the language in settings is set to a different language #26672

Open
mattermod opened this issue Apr 5, 2024 · 10 comments
Assignees
Labels
Difficulty/1:Easy Easy ticket Help Wanted Community help wanted Tech/ReactJS Web app

Comments

@mattermod
Copy link
Contributor

mattermod commented Apr 5, 2024

Original ticket: #21552

Summary

The html tag always defines the language of the page to <html lang="en">. We want this to be set to the “DefaultClientLocale”, that can be found in the config. If there is no value in the config, we can set it to unknown.

The objective of this is so browsers translate the content of the site (the messages in the posts) from the language the server is in theory using.


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-48048

@mattermod mattermod added Help Wanted Community help wanted Up For Grabs labels Apr 5, 2024
@larkox larkox added Difficulty/1:Easy Easy ticket Tech/ReactJS Web app labels Apr 5, 2024
@larkox
Copy link
Contributor

larkox commented Apr 5, 2024

@sapnasivakumar
Copy link
Contributor

@larkox I would like to work on this ticket. Can you please assign this to me.
(Will take a note of the previous approaches added in the description)

@larkox
Copy link
Contributor

larkox commented Apr 11, 2024

@sapnasivakumar All yours! Thank you 😄

@fasal26
Copy link
Contributor

fasal26 commented Apr 25, 2024

@sapnasivakumar , are you actively monitoring this issue? It has been two weeks since the last comment.
@larkox , I would like to work on this one if no one is actively monitoring it

@larkox
Copy link
Contributor

larkox commented Apr 25, 2024

@fasal26 If @sapnasivakumar doesn't answer in a couple of days, feel free to take it.

@fasal26
Copy link
Contributor

fasal26 commented Apr 25, 2024

Got it

@sapnasivakumar
Copy link
Contributor

@fasal26 I'm having a look at this ticket.
In case I'm unable to I'll contact you to take it on

@fasal26
Copy link
Contributor

fasal26 commented Apr 26, 2024

Sure thing @sapnasivakumar

@fasal26
Copy link
Contributor

fasal26 commented May 1, 2024

@sapnasivakumar hey there, how is it going did u find the issue ?

@sapnasivakumar
Copy link
Contributor

sapnasivakumar commented May 2, 2024

@fasal26 I'm on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/1:Easy Easy ticket Help Wanted Community help wanted Tech/ReactJS Web app
Projects
None yet
Development

No branches or pull requests

5 participants