Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pasting a URL using ctrl+V should create a link, even when editing an existing message #26675

Open
biva opened this issue Apr 5, 2024 · 5 comments · May be fixed by #27097
Open

Pasting a URL using ctrl+V should create a link, even when editing an existing message #26675

biva opened this issue Apr 5, 2024 · 5 comments · May be fixed by #27097
Assignees
@cyrusjc
Labels
Help Wanted Community help wanted

Comments

@biva
Copy link

biva commented Apr 5, 2024 •
edited

Summary

Bug report in one concise sentence

Steps to reproduce

  1. Start a new message, Write Hello.
  2. Copy a URL somewhere (for example https://github.com/)
  3. Select Hello and press CTRL + V → this creates a link: [Hello](https://github.com/)
  4. Send your message
  5. Edit this message and write Mary
  6. Do the same: select it and press CTRL + V → this replaces Mary by the URL

Expected behavior

  1. A link should be created, like in step 3

I also see in https://docs.mattermost.com/collaborate/format-messages.html that:

Format selected message text as a link by pressing Ctrl K on Windows and Linux, or by pressing ⌘ K on Mac.

I also mention #26399 because this is related

While Ctrl K on Windows triggers a search, not a link.
@biva biva mentioned this issue Apr 5, 2024
Open
@amyblais
Copy link
Member

amyblais commented Apr 5, 2024

Opened https://mattermost.atlassian.net/browse/MM-57729.

@amyblais amyblais added the Bug Report/Open Bug report/issue label Apr 5, 2024
@cyrusjc
Copy link

cyrusjc commented May 21, 2024

Hi I'd like to work on this

@amyblais amyblais added Help Wanted Community help wanted and removed Bug Report/Open Bug report/issue labels May 21, 2024
@cyrusjc
Copy link

cyrusjc commented May 22, 2024

I also see in https://docs.mattermost.com/collaborate/format-messages.html that:

Format selected message text as a link by pressing Ctrl K on Windows and Linux, or by pressing ⌘ K on Mac.

I also mention #26399 because this is related

While Ctrl K on Windows triggers a search, not a link.

Regarding this issue, is that a docs issue or is the window shortcut incorrect? In the app, ctrl + alt + k is the shortcut that applies the link markdown.

@cyrusjc cyrusjc linked a pull request May 22, 2024 that will close this issue
Open
@cyrusjc
Copy link

cyrusjc commented Jun 6, 2024

Hi can I get someone to review this pr? It's been up for quite awhile with no reviewers attached:

#27097

@amyblais
Copy link
Member

amyblais commented Jun 6, 2024

Hi can I get someone to review this pr? It's been up for quite awhile with no reviewers attached:

#27097

I've assigned reviewers now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cyrusjc cyrusjc

Labels
Help Wanted Community help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MM-26675] Copy paste applies l ink markdown in edit_textbox cyrusjc/mattermost
3 participants
@biva @amyblais @cyrusjc