Skip to content

Commit

Permalink
PLT-5281 error messages contain a link to documentation about reserve…
Browse files Browse the repository at this point in the history
…d words
  • Loading branch information
aautio committed Feb 25, 2017
1 parent 97cc0a0 commit 8f9530c
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
6 changes: 3 additions & 3 deletions webapp/components/create_team/components/team_url.jsx
Expand Up @@ -81,9 +81,9 @@ export default class TeamUrl extends React.Component {
for (let index = 0; index < Constants.RESERVED_TEAM_NAMES.length; index++) {
if (cleanedName.indexOf(Constants.RESERVED_TEAM_NAMES[index]) === 0) {
this.setState({nameError: (
<FormattedMessage
<FormattedHTMLMessage
id='create_team.team_url.taken'
defaultMessage='URL is taken or contains a reserved word'
defaultMessage='This URL <a href="https://docs.mattermost.com/help/getting-started/creating-teams.html#team-url" target="_blank">starts with a reserved word</a> or is unavailable. Please try another.'
/>)
});
return;
Expand All @@ -101,7 +101,7 @@ export default class TeamUrl extends React.Component {
this.setState({nameError: (
<FormattedMessage
id='create_team.team_url.unavailable'
defaultMessage='This URL is unavailable. Please try another.'
defaultMessage='This URL is taken or unavailable. Please try another.'
/>)
});
this.setState({isLoading: false});
Expand Down
4 changes: 2 additions & 2 deletions webapp/i18n/en.json
Expand Up @@ -1217,9 +1217,9 @@
"create_team.team_url.hint": "<li>Short and memorable is best</li><li>Use lowercase letters, numbers and dashes</li><li>Must start with a letter and can't end in a dash</li>",
"create_team.team_url.regex": "Use only lower case letters, numbers and dashes. Must start with a letter and can't end in a dash.",
"create_team.team_url.required": "This field is required",
"create_team.team_url.taken": "URL is taken or contains a reserved word",
"create_team.team_url.taken": "This URL <a href=\"https://docs.mattermost.com/help/getting-started/creating-teams.html#team-url\" target=\"_blank\">starts with a reserved word</a> or is unavailable. Please try another.",
"create_team.team_url.teamUrl": "Team URL",
"create_team.team_url.unavailable": "This URL is unavailable. Please try another.",
"create_team.team_url.unavailable": "This URL is taken or unavailable. Please try another.",
"create_team.team_url.webAddress": "Choose the web address of your new team:",
"custom_emoji.empty": "No custom emoji found",
"custom_emoji.header": "Custom Emoji",
Expand Down
5 changes: 5 additions & 0 deletions webapp/sass/responsive/_mobile.scss
Expand Up @@ -1625,6 +1625,11 @@ label span {
pointer-events: none;
}

// PLT-5281: link inside a localized message was not clickable because of the rule above
label span a {
pointer-events: all;
}

@media screen and (-webkit-min-device-pixel-ratio: 0) {
select,
textarea,
Expand Down

0 comments on commit 8f9530c

Please sign in to comment.