Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added build script which helps to build platform package #3359

Closed
wants to merge 1 commit into from

Conversation

kayrus
Copy link

@kayrus kayrus commented Jun 16, 2016

This script helps to build mattermost in docker environment.

@mattermod
Copy link
Contributor

Thanks @kayrus for the pull request!

Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?

This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.

Please let us know if you have any questions.

We are very happy to have you join our growing community!

@coreyhulen coreyhulen added 2: Dev Review Requires review by a developer 1: PM Review Requires review by a product manager labels Jun 16, 2016
@crspeller
Copy link
Member

Hi @kayrus

We already have a preview docker image. You can find it here: https://github.com/mattermost/mattermost-docker-preview

Thanks for you interest!

Closing as duplicate.

@crspeller crspeller closed this Jun 22, 2016
@kayrus
Copy link
Author

kayrus commented Jun 22, 2016

@crspeller this image is not for running mattermost, it is for building mattermost.

@crspeller
Copy link
Member

Why do you want a docker image for building mattermost?

@kayrus
Copy link
Author

kayrus commented Jun 22, 2016

@crspeller because I don't want to install nodejs and tons of dev stuff on my host.

@crspeller
Copy link
Member

For development or for use?
We have releases to download here: http://www.mattermost.org/download/

@kayrus
Copy link
Author

kayrus commented Jun 22, 2016

@crspeller of course for development. guys, just take a look at the code and what it does. some users just want to compile whole package without installing additional soft, just use docker. you don't have to configure go env, install node, just run the script. this is normal practise.

@kayrus
Copy link
Author

kayrus commented Jul 7, 2016

@crspeller did you abandon this PR?

@it33
Copy link
Contributor

it33 commented Jul 8, 2016

Hi @kayrus,

Definitely appreciate your work. I can see why you would want this and it's clear you've spent a considerable amount of effort trying to improve the product--not only in the code, but engaging in the discussion.

Per the contribution guide, we try to be transparent about the process in place to make sure system improvements have the right level of design critique, discussion, testing, documentation and long term support before we can accept them.

The first step of this process is making a contribution to the feature idea forum where your idea can be discussed and upvoted by the community.

Would you be open to this as a starting point?

@kayrus
Copy link
Author

kayrus commented Jul 11, 2016

@it33 It is quite weird workflow for an opensource product. It adds a barrier which prevents contribution to the project and complicates PR from the community side. I'd suggest you to simplify this process.

Anyway, here is my "idea".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: PM Review Requires review by a product manager 2: Dev Review Requires review by a developer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants