Keys for Asteroids Deluxe don't work

[mattgodbolt]

[from the author! yay] : "The only trouble is the keys don't quite work properly:

Ctrl turns right
Caps Lock turns left continuously when enabled but I think holding Shift should turn left - I can't quite remember.
] is thrust but I'm not sure that's right

...I've only tried it in Safari and Chrome on a MacBook with UK keyboard layout though. Elite and Defender seem to work OK.."

[mattgodbolt]

Keys work OK on my US laptop.

[murkle]

http://bbc.godbolt.org/?disc=%7CAtarisoft%2FAsteroidsDeluxe.zip&autoboot
UK Keyboard, Chrome, Win 8.1
all keys seem OK here (no "sticking"). Shift doesn't do anything. Is he using the same disc image?
Capslock: turn left
Ctrl: turn right
[: Thrust
Space: Shield
Enter: Fire

[mattgodbolt]

That's the one he linked, yes -- I wonder what's going on. I'll get his Chrome version.

[mattgodbolt]

" MacBook Pro Retina 16GB (Late 2013)
UK keyboard (build-in to MacBook)

System Version: OS X 10.9.5 (13F34)
Kernel Version: Darwin 13.4.0

Safari          Version 7.1 (9537.85.10.17.1)
Google Chrome   Version 38.0.2125.104

"

[jlarcombe]

For what it's worth, I noticed yesterday that the same thing happens in Zalaga running in Chrome on the Mac, and presumably any other game that uses caps lock to move left. Haven't debugged it, but it's as though jsbeeb 'sees' the key being held down continuously while the system's real caps lock is enabled.

[mattgodbolt]

Ah that could well be it! Thanks for the hint; though I'm not quite sure how one might go about fixing it.

My caps lock key is configured as a completely different key so I've not seen the problem :)

[jlarcombe]

Looking around, it seems as though this would be impossible to fix without a change to the browsers. Cocoa simply doesn't issue key up events for caps lock. They'd have to go down to a lower layer (IOHIDManager) and that would be a pain because it wouldn't come through the normal event loop. The Qt and Firefox developers have had the same problem (https://bugzilla.mozilla.org/show_bug.cgi?id=712535, https://bugreports.qt.io/browse/QTBUG-46549).

The 'Gaming' keyboard layout works around the problem in jsbeeb, of course.

[murkle]

Another solution :)
http://bbc.godbolt.org/?autoboot&disc=sth%3AAardvark%2FZalaga.zip&KEY.A=CAPSLOCK&KEY.S=CTRL&keyLayout=physical#