Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies to the latest versions #69

Closed
wants to merge 1 commit into from

Conversation

nightwolfz
Copy link

All tests pass, what else can I say?

packages.json

 node-fetch     1.0.1  →   1.3.3
 whatwg-fetch  0.10.0  →  0.11.0
 jshint          2.5.11  →  2.9.1
 mocha            2.1.0  →  2.3.4
 npm-prepublish   1.0.2  →  1.2.1

bower.json

"dependencies": {
    "fetch": "github/fetch#>=0.11.0"
  }

@matthew-andrews
Copy link
Owner

I don't think this does anything except potentially disrupt people who, for whatever reason, need to use old versions. The versions that you've updated to in dependencies are satisfied by the previous rules…

I'd be happy to accept a pull request that just updated the devDependencies though.

@lucasfeliciano
Copy link

@matthew-andrews I really need this merged:

I bumped in this problem: facebook/react-native#5667

After a long day of research I realised that is related to this issue into the github fetch module: JakeChampion/fetch#125

And if you see the changelog of the the fetch repo you find that the bug was fixed on version 0.11.0: https://github.com/github/fetch/releases

Would be nice to have this merged, otherwise I would need to fork of this project to use it :(

@matthew-andrews
Copy link
Owner

@lucasfeliciano but the previous semver should allow v0.11.0?

Also I think the self issue is currently an issue for this repo as well.

Have you tried this branch?
https://github.com/matthew-andrews/isomorphic-fetch/pull/63/files

@lucasfeliciano
Copy link

That is exactly where the problem occurs in my current version.
That is the issue ;)

But this PR have the same fix that the whatwg-fetch made.

@matthew-andrews
Copy link
Owner

So can I close this pull request? I don't think this pull request does anything except potentially break this module for other consumers……

@lucasfeliciano
Copy link

The thing is, if you update the version of the fetch you dont need that fix.

Not 100% sure, because when I was forking to debug you replied me but yeah.

I think it is better to update the dependency than make the same changes in this repo

@matthew-andrews
Copy link
Owner

The semver constraint in the master branch for fetch is currently >=0.10.0, see:-

https://github.com/matthew-andrews/isomorphic-fetch/blob/master/bower.json#L5
https://github.com/matthew-andrews/isomorphic-fetch/blob/master/package.json

This means that when you install this module you should get the latest version of whatwg-fetch.

I have just checked this:-

$ echo {} > package.json
$ npm install --save isomorphic-fetch
npm WARN package.json @ No description
npm WARN package.json @ No repository field.
npm WARN package.json @ No README data
isomorphic-fetch@2.2.1 node_modules/isomorphic-fetch
├── whatwg-fetch@0.11.0
└── node-fetch@1.3.3 (encoding@0.1.12)

^^ it gets whatwg-fetch@0.11.0

@lucasfeliciano
Copy link

Indeed, just checked this.

So we need this ( https://github.com/matthew-andrews/isomorphic-fetch/pull/63/files ) merged.

Just tested it and fix the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants