Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delocate-wheel exits 'succesfully' after encountering potential errors. #90

Closed
HexDecimal opened this issue Dec 30, 2020 · 1 comment · Fixed by #94
Closed

delocate-wheel exits 'succesfully' after encountering potential errors. #90

HexDecimal opened this issue Dec 30, 2020 · 1 comment · Fixed by #94

Comments

@HexDecimal
Copy link
Collaborator

I've recently ran into a problem where updating a dependency I was using added another dependency which failed to be included by delocate-wheel. Because delocate-wheel doesn't exit with an error code on warnings I didn't find out there was an issue until sometime later. Example output:

delocate-wheel -v dist/*.whl
/Users/runner/work/python-tcod/python-tcod/venv/lib/python3.7/site-packages/delocate/libsana.py:111: UserWarning: Couldn't find @rpath/hidapi.framework/Versions/A/hidapi on paths:
Fixing: dist/tcod-11.19.1-cp35-abi3-macosx_10_9_x86_64.whl
	/Users/runner/work/python-tcod/python-tcod/@executable_path/Frameworks
Copied to package .dylibs directory:
	/Users/runner/work/python-tcod/python-tcod/@loader_path/Frameworks
  '\n\t'.join(realpath(path) for path in rpaths),
  /Users/runner/work/python-tcod/python-tcod/dependencies/SDL2-2.0.14/SDL2.framework/Versions/A/SDL2
/Users/runner/work/python-tcod/python-tcod/venv/lib/python3.7/site-packages/delocate/libsana.py:111: UserWarning: Couldn't find @rpath/hidapi.framework/Versions/A/hidapi on paths:
/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit
	/Users/runner/work/python-tcod/python-tcod/@executable_path/Frameworks
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices
	/Users/runner/work/python-tcod/python-tcod/@loader_path/Frameworks
/System/Library/Frameworks/AudioToolbox.framework/Versions/A/AudioToolbox
  '\n\t'.join(realpath(path) for path in rpaths),

I'd like to suggest a command line argument to determine if warnings like these return an error code instead of passing silently in scripts, or maybe even change the default behavior of when libraries aren't found to return an error by default with an option to allow the behavior.

I think I could implement this myself if you decide what the policy should be.

@matthew-brett
Copy link
Owner

matthew-brett commented Dec 30, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants