Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work when more than one space in a name #1

Closed
saewitz opened this issue Dec 14, 2020 · 1 comment
Closed

Doesn't work when more than one space in a name #1

saewitz opened this issue Dec 14, 2020 · 1 comment

Comments

@saewitz
Copy link

saewitz commented Dec 14, 2020

Hi, cool extension!

Just a note, it doesn't work when a professor has more than one space in their name. This is because of how the extension handles names on Testudo. Here are the relevant lines: https://github.com/MatthewFoulk/UMDProfessorRatings/blob/master/content.js#L60-L63

@MatthewFoulk
Copy link
Owner

Thanks for the feedback! I've added some minor changes to handle multi-spaced names. Once the updated version is approved by the Chrome Web Store, it should be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants