Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add government lookup requests #45

Closed
dcragusa opened this issue Sep 7, 2018 · 4 comments
Closed

Add government lookup requests #45

dcragusa opened this issue Sep 7, 2018 · 4 comments

Comments

@dcragusa
Copy link

dcragusa commented Sep 7, 2018

A function that returns a list of tickers corresponding to a generic govt. security such as 'T Govt'.

I don't feel comfortable opening a pull request due to so many style changes, but an implementation can be found in my fork here.

@matthewgilbert
Copy link
Owner

matthewgilbert commented Sep 7, 2018

This looks interesting. I agree that a pull request in its current form wouldn't make sense since there is a lot going on here and I prefer sticking to atomic commits. Reproducing from your commits I see the following changes:

  • Add type hints
  • Refactor receiving events
  • Simplify message parsing
  • Robustify function arguments
  • Add govt list function and test coverage
  • Style changes
  • Allow for changing host in unit testing

When I get some spare time I will look to incorporate some of these changes. I think most things look good although I will likely hold off on introducing types since this is a fairly major change and I would like to give it some thought prior to introducing the change. I would be happy to receive atomic commits on any of the above changes excluding the type hints.

@dcragusa
Copy link
Author

dcragusa commented Sep 7, 2018

That sounds good, I will make a separate branch with atomic commits sans type hints.

@matthewgilbert
Copy link
Owner

matthewgilbert commented Sep 10, 2018

@dcragusa Some of these are now done. The features from your branch I have incorporated in recent commits 8340f32, d78791d, c3ae2e5 are:

  • Refactor logger setup to improve clarity
  • Refactor event handling into _receive_events()
  • Allow changing host in conjunction with general refactoring of tests to use pytest

@dcragusa
Copy link
Author

Excellent, I will PR the govt list function soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants