-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add government lookup requests #45
Comments
This looks interesting. I agree that a pull request in its current form wouldn't make sense since there is a lot going on here and I prefer sticking to atomic commits. Reproducing from your commits I see the following changes:
When I get some spare time I will look to incorporate some of these changes. I think most things look good although I will likely hold off on introducing types since this is a fairly major change and I would like to give it some thought prior to introducing the change. I would be happy to receive atomic commits on any of the above changes excluding the type hints. |
That sounds good, I will make a separate branch with atomic commits sans type hints. |
@dcragusa Some of these are now done. The features from your branch I have incorporated in recent commits 8340f32, d78791d, c3ae2e5 are:
|
Excellent, I will PR the govt list function soon. |
A function that returns a list of tickers corresponding to a generic govt. security such as 'T Govt'.
I don't feel comfortable opening a pull request due to so many style changes, but an implementation can be found in my fork here.
The text was updated successfully, but these errors were encountered: