Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window[_orientation_event] = _handleOrientation; is error #44

Open
blank opened this issue Nov 13, 2013 · 0 comments
Open

window[_orientation_event] = _handleOrientation; is error #44

blank opened this issue Nov 13, 2013 · 0 comments
Labels
bug-major Bugs that are affecting production users.

Comments

@blank
Copy link

blank commented Nov 13, 2013

in https://github.com/matthewhudson/device.js/blob/master/lib/device.js

window[_orientation_event] = _handleOrientation;

is error, right is:

window['on' + _orientation_event] = _handleOrientation;

@matthewhudson matthewhudson added bug-major Bugs that are affecting production users. Difficulty: Beginner labels Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-major Bugs that are affecting production users.
Projects
None yet
Development

No branches or pull requests

2 participants