-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow numbers on module name #7
Comments
Okay I can see why it is, the regexp only allow a minimum of 3 characters. Same is happening for the creation of a namespace call db
perhaps it would be acceptable to change it to:
|
Actually if you don't want to allow the first character to be _ or - then it will be the opposite if not re.match(r'^[0-9A-Za-z][0-9a-zA-Z-_]+$', name): |
Hey @jose-sky , Thanks for raising this :) I'd be a little concerned with starting/ending with dash/underscore - how would this sound?
So at least 2 characters of: any alpha-numeric character at beginning and end, with dashes/underscores allowed in the characters in-between? Many thanks |
Hey @jose-sky Assuming you're happy with this suggestion, I've made an upstream ticket (https://gitlab.dockstudios.co.uk/pub/terrareg/-/issues/397) and a PR with the fix (https://gitlab.dockstudios.co.uk/pub/terrareg/-/merge_requests/332). Let me know if you're happy/have any concerns with this implementation and I'll merge once you've confirmed :) Many thanks |
This sounds great and cover all our use case for now 👍 Thanks |
Excellent - I'll merge the PR :) Apologies, I heard about the mail delivery issues - hopefully they should be sorted now :) |
That's now merged and released in v2.69.0 :) |
Add button to UI to sign in via SSO. Add endpoints to initiate authentication flow and handle callback from provider Issue MatthewJohn#7
Update authentication handling to differenciate between password and OpenID-based authentication. Create common method to create session and use for password authentication and OpenID-based authentication. Issue MatthewJohn#7
Callers of create_session expect None when a session was not successfully created Issue MatthewJohn#7
…ts for testing OpenID authentication Issue MatthewJohn#7
…ing the application Issue MatthewJohn#7
…and generate config Issue MatthewJohn#7
…authentication check Issue MatthewJohn#7
…r than SSO and assert custom button text works Issue MatthewJohn#7
Issue MatthewJohn#7
…nect_login test Issue MatthewJohn#7
…e certificate environment variables Issue MatthewJohn#7
# [2.42.0](https://gitlab.dockstudios.co.uk/pub/terrareg/compare/v2.41.0...v2.42.0) (2022-10-01) ### Bug Fixes * Fix logout icon ([cd343cb](https://gitlab.dockstudios.co.uk/pub/terrareg/commit/cd343cbd58de011a9d67e182934512a1e8cc3d9f)), closes [MatthewJohn#7](https://gitlab.dockstudios.co.uk/pub/terrareg/issues/7) ### Features * Implement OpenID and SAML authentication ([c611a7c](https://gitlab.dockstudios.co.uk/pub/terrareg/commit/c611a7cb7c506c9744dd30c7acec8ea8ce0cad9a))
Hi,
Feature request
I would like to name my module S3. Right now that is throwing an error. It doesn't say specifically the problem but I assume is the number.
Module name is invalid
The text was updated successfully, but these errors were encountered: