Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quotes in attributes not escaped #26

Closed
lamplightdev opened this issue Aug 27, 2021 · 3 comments
Closed

Quotes in attributes not escaped #26

lamplightdev opened this issue Aug 27, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@lamplightdev
Copy link
Contributor

Attributes should have any " replaced with " to prevent premature closing of the values. Think this is a simple one to fix, I can submit an PR.
@lamplightdev
Copy link
Contributor Author

Similar to how it's handled in linkedom: https://github.com/WebReflection/linkedom/blob/21551c61e021bac99120c79a8b3b667118cc8ecb/esm/interface/attr.js#L45

@matthewp
Copy link
Owner

Thanks, I would appreciate it!

@matthewp matthewp added the bug Something isn't working label Aug 28, 2021
@matthewp
Copy link
Owner

Fixed by #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matthewp @lamplightdev