Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

52+ errors... XCode 8 #145

Closed
mdridley opened this issue Sep 14, 2016 · 14 comments
Closed

52+ errors... XCode 8 #145

mdridley opened this issue Sep 14, 2016 · 14 comments

Comments

@mdridley
Copy link

Finally updating a new project to Swift 3.0... but having trouble with LockSmith:

I tried downloading the 3.0 branch code and replacing the files... but still seems like a lot of broken stuff. I feel like I must be doing something wrong on my end. Or did some stuff change last minute that is breaking the last 3.0 changes?

image

@thatjuan
Copy link

@mdridley Are you using cocoapods? Just wondering. I'm having a heck of a time upgrading all my project dependencies, Locksmith being one of them.

@mdridley
Copy link
Author

mdridley commented Sep 14, 2016

I am. Only one that is still having an issue. Got the rest of my project updated.

@rlam3
Copy link

rlam3 commented Sep 14, 2016

+1

@mdridley mdridley changed the title 53+ errors... XCode 8 52+ errors... XCode 8 Sep 14, 2016
@matthewpalmer
Copy link
Owner

matthewpalmer commented Sep 14, 2016

Hmm, could be wrong but I don't think you're using the latest from swift-3.0. The code you posted isn't updated for Swift 3.0, it's been replaced with the snippet below. What are steps to reproduce this issue?

public extension SecureStorable where Self : InternetPasswordSecureStorable {
    fileprivate var internetPasswordBaseStoragePropertyDictionary: [String: Any] {
        var dictionary = [String: Any]()

        // add in whatever turns out to be required...
        dictionary[String(kSecAttrServer)] = server
        dictionary[String(kSecAttrPort)] = port
        dictionary[String(kSecAttrProtocol)] = internetProtocol.rawValue
        dictionary[String(kSecAttrAuthenticationType)] = authenticationType.rawValue
        dictionary[String(kSecAttrSecurityDomain)] = securityDomain
        dictionary[String(kSecAttrPath)] = path
        dictionary[String(kSecClass)] = LocksmithSecurityClass.internetPassword.rawValue

        let toMergeWith = [
            accountSecureStoragePropertyDictionary,
            describableSecureStoragePropertyDictionary,
            commentableSecureStoragePropertyDictionary,
            creatorDesignatableSecureStoragePropertyDictionary,
            typeDesignatableSecureStoragePropertyDictionary,
            isInvisibleSecureStoragePropertyDictionary,
            isNegativeSecureStoragePropertyDictionary
        ]

@ehabsaifan
Copy link

I have the same issue... Just like you

@matthewpalmer
Copy link
Owner

Can you please provide more info?

On 15 Sep. 2016, at 8:37 am, Ehab Saifan notifications@github.com wrote:

I have the same issue... Just like you


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@ehabsaifan
Copy link

This my Podfile, and I am using cocoPods 1.1.0
`# Uncomment this line to define a global platform for your project

platform :ios, ‘9.0’

use_frameworks!

target ‘Dropspot’ do
pod 'MBProgressHUD'
pod 'SwiftyJSON'
pod 'Alamofire', '~> 4.0'
pod 'Stripe'
pod 'Bolts'
pod 'FBSDKCoreKit'
pod 'FBSDKShareKit'
pod 'FBSDKLoginKit'
pod 'AWSCore'
pod 'AWSS3'
pod 'Locksmith',
:git => 'https://github.com/davbeck/Locksmith.git',
:branch => 'swift-3.0'
pod 'Google/Analytics'
pod 'SwiftQRCode'
end

post_install do |installer|
installer.pods_project.targets.each do |target|
target.build_configurations.each do |config|
config.build_settings['SWIFT_VERSION'] = '3.0'
end
end
end
`

I have the same issues as "mdridley"

@matthewpalmer
Copy link
Owner

You are using https://github.com/davbeck/Locksmith.git not this repo

@ehabsaifan
Copy link

I am new to iOS I appreiate your help! Could you please explain more

@matthewpalmer
Copy link
Owner

Replace https://github.com/davbeck/Locksmith.git with https://github.com/matthewpalmer/Locksmith.git in your podfile and let me know how it goes 👍

@ehabsaifan
Copy link

Thank You I guess the problem resolved :) 👍

@mdridley
Copy link
Author

Updating podfile as suggested worked. Thank you!!!

@siavashalipour
Copy link

@matthewpalmer Could you please add a release version as well? I can't use this branch as an dependency in podspec

@matthewpalmer
Copy link
Owner

@siavashalipour done. Closing this issue now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants