Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform image extensions #439

Open
kukosk opened this issue Nov 4, 2017 · 0 comments
Open

Uniform image extensions #439

kukosk opened this issue Nov 4, 2017 · 0 comments

Comments

@kukosk
Copy link

kukosk commented Nov 4, 2017

Today I encountered an issue with image file extensions. I uploaded a '.jpeg' file to my Django app, and found out imagekit used that extension also to store the converted image file. I then looked into the lib code, and found out it's actually a desired behaviour (suggest_extension function), but I think it would be better to use default extensions for file formats. I know it's a minor thing, but I don't like the fact that mixed extensions would be used for the same formats just because the user uploads a picture with a different extension. I know this can be fixed by using a different extension in the upload_to attribute, but I'm generating that from the filename of the file the user uploads, so that I can support multiple extensions in some other parts of my app.

Don't you think it would be better to remove the logic that gives precedence to the original extension?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant