Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing "save connection" behavior #48

Open
Fensterbank opened this issue Apr 23, 2020 · 4 comments
Open

Confusing "save connection" behavior #48

Fensterbank opened this issue Apr 23, 2020 · 4 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@Fensterbank
Copy link

What happens:

  • When pressing "+" the form to create a new connection will open
  • When I press "Save connection" while having an open connection, this connection will be saved
    grafik

The button has nothing to do with the form, it is bound to the active connection.
This explains why this button was disabled when I created the first connection. I was confused, I cannot save it, but the reason was that I did not have an active connection.

What do users expect:

  • The button should act as a flag, if the connection I'm just creating should be saved in the library.
  • With the current functionality of the button, it should not be part of the form
@matthiaaas matthiaaas added bug Something isn't working enhancement New feature or request labels Apr 23, 2020
@matthiaaas
Copy link
Owner

matthiaaas commented Apr 23, 2020

Agree. Added a bookmark action item to the Dashboard in 1c8a4b0

grafik

Should it be removed from the login?

@tobimori
Copy link
Collaborator

@matthiaaas I'd rather change its behaviour to a check box, so that'll save it after a succesful connection.

@Fensterbank
Copy link
Author

I agree on both cases.

  • If it's not yet bookmarked, a bookmark action items on the Dashboard makes sense.
  • When creating a connection in most cases I already know if I want to bookmark it, so a checkbox to bookmark it after a successful connection would be good.

@Dudeplayz
Copy link

  1. The bookmark action item should be always visible to also allow removing of the bookmark. Indicated by filled or unfilled icon.
  2. Agree to checkbox.
  3. Make it possible to add a bookmark without connecting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants