Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5-in-1 and 6-in-1 Decoder fail after PR #40 #45

Closed
matthias-bs opened this issue Mar 9, 2023 · 4 comments · Fixed by #46
Closed

5-in-1 and 6-in-1 Decoder fail after PR #40 #45

matthias-bs opened this issue Mar 9, 2023 · 4 comments · Fixed by #46
Labels
bug Something isn't working

Comments

@matthias-bs
Copy link
Owner

matthias-bs commented Mar 9, 2023

@jorgenavarroortiz: The 6-in-1 decoder fails with "Digest check failed" after integrating #40.

@matthias-bs matthias-bs added the bug Something isn't working label Mar 9, 2023
@matthias-bs matthias-bs changed the title 6-in-1 Decoder fails PR #40 6-in-1 Decoder fails after PR #40 Mar 9, 2023
@matthias-bs
Copy link
Owner Author

In decodeBresser7In1Payload(), the "data whitening" modifies the payload buffer in-place, rendering it useless for subsequent decoding attempts.

@jorgenavarroortiz Please make a local copy of the payload buffer (strongly preferred) or move this decoder to the end of the chain.

@matthias-bs
Copy link
Owner Author

Workaround: Comment out #define BRESSER_7_IN_1 in

.

@matthias-bs matthias-bs changed the title 6-in-1 Decoder fails after PR #40 5-in-1 and 6-in-1 Decoder fail after PR #40 Mar 9, 2023
@jorgenavarroortiz
Copy link
Contributor

Hi! I have submit a pull request. I have made a local copy of the payload buffer. It works with my weather station (7-in-1). Please test it with the other weather stations (5-in-1 and 6-in-1), it should work.

@matthias-bs
Copy link
Owner Author

Looks good! I'll check it tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants