Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain functions do not overload counterparts in LinearAlgebra #7

Closed
BenjaminRemez opened this issue Mar 26, 2024 · 1 comment
Closed

Comments

@BenjaminRemez
Copy link

Some functions (so far I noticed rank and inv) do not overload their counterparts in LinearAlgebra. using Modulo2, LinearAlgebra pollutes the namespace with e.g. two rank functions that must be disambiguated and thus one cannot dispatch on the type of the matrix. Is this intentional? If not, I am happy to commit a fix.

matthias314 added a commit that referenced this issue Mar 26, 2024
@matthias314
Copy link
Owner

inv is defined in Base, so there should be no problem. For rank, however, this is an oversight. I've just fixed it on master. Thanks for reporting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants