Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 doesn't support anything useful #110

Merged
merged 1 commit into from Sep 2, 2014
Merged

IE8 doesn't support anything useful #110

merged 1 commit into from Sep 2, 2014

Conversation

attilaolah
Copy link
Collaborator

Hi,

I just downloaded /! WOW - v1.0.1 - 2014-08-15/
and ran the demo ie8 with saucelabs and get an error with ie8.

http://mtc2.taichungdesigner.com/WOW-master/demo.html

Message: Object doesn't support this property or method
Line: 320
Char: 9
Code: 0
URI: http://mtc2.taichungdesigner.com/WOW-master/dist/wow.js

Any ideas?

Thanks,

Robert

@iamrobert iamrobert changed the title ie* issue ie8 issue Sep 1, 2014
@iamrobert
Copy link
Author

If you wrap the initialize script the bug disappears:

<!--[if gt IE 8]><!-->
<script>
new WOW().init();  
</script>
<!--<![endif]-->

@attilaolah attilaolah changed the title ie8 issue IE8 doesn't support window.getComputedStyle Sep 1, 2014
@attilaolah
Copy link
Collaborator

This is because IE8 doesn't support window.getComputedStyle. We could look for a shim/replacement I guess.

@attilaolah
Copy link
Collaborator

This answer on StackOverflow or this shim could be useful.

@attilaolah attilaolah added the bug label Sep 1, 2014
@attilaolah attilaolah self-assigned this Sep 1, 2014
attilaolah pushed a commit that referenced this pull request Sep 2, 2014
IE8 doesn't support window.getComputedStyle
@attilaolah attilaolah merged commit 983ee02 into master Sep 2, 2014
@attilaolah attilaolah deleted the issue-110 branch September 2, 2014 18:34
@attilaolah
Copy link
Collaborator

@iamrobert, please try this fix, if it works for you, I'll release a new version.

@iamrobert
Copy link
Author

@attilaolah - thanks however now I am getting a different webpage error:

Message: Object doesn't support this property or method
Line: 163
Char: 11
Code: 0
URI: http://mtc2.taichungdesigner.com/WOW-master/dist/wow.js

This line:

window.addEventListener('scroll', this.scrollHandler, false);

@attilaolah
Copy link
Collaborator

@iamrobert please see #113.

@iamrobert
Copy link
Author

@attilaolah - still showing:

Webpage error details
Message: 'innerHeight' is undefined
Line: 426
Char: 7
Code: 0
URI: http://mtc2.taichungdesigner.com/WOW-master/dist/wow.js

@attilaolah
Copy link
Collaborator

💩 this is endless, is anything supported by IE8‽

@attilaolah
Copy link
Collaborator

@iamrobert 82f1996 should have fixed that last issue, can you please retry again?

@attilaolah attilaolah changed the title IE8 doesn't support window.getComputedStyle IE8 doesn't support anything useful Sep 3, 2014
@iamrobert
Copy link
Author

Thanks for trying and there are now no bugs - however the screen is totally blank.

So - I am thinking of using conditional comments for the initialize might be a better bet or css to specifically target ie8.

nothing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants