Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links to pdf files #18

Closed
mattias-p opened this issue Mar 6, 2018 · 3 comments
Closed

Links to pdf files #18

mattias-p opened this issue Mar 6, 2018 · 3 comments
Labels
bug

Comments

@mattias-p
Copy link
Owner

Allow links to pdf files. Today they're resolved to status DEC_ERR even though they aren't even text files.
@mattias-p mattias-p added the bug label Mar 6, 2018
@mattias-p
Copy link
Owner Author

Character decoding should never be done for non-text MIME types.

@mattias-p
Copy link
Owner Author 

$ cat test.md
[pdf.pdf](http://www.pdf995.com/samples/pdf.pdf)
$ env RUST_LOG=warn target/debug/linky --check test.md
WARN :linky::linky: warn: Link: http://www.pdf995.com/samples/pdf.pdf
WARN :linky::linky:   caused by: Decoding error
WARN :linky::linky:   caused by: Failed to detect character encoding
pdf.md:1: DEC_ERR http://www.pdf995.com/samples/pdf.pdf

mattias-p added a commit that referenced this issue Mar 15, 2018
@mattias-p
Refactor document resolution
c4f58b1 
Fixes #17 and #18
@mattias-p
Copy link
Owner Author

Fix on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattias-p