Minor fixes to some of the info generating code #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures trailing spaces don't affect punctuation. Ensures second route to a valid description is punctuated and that keywords are prefixed with "Nyckelord".
I am worried that there is a case where OK_to_upload is True but no description is generated when: "Beskrivning" is None "Ort, foto" is not None any of "Motivord", "Händelse / var närvarande vid" is None If this scenario ever occurs then a message will be outputted to the user. To make it more obviouse I've commented out some now unneded print statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info in the individual commit messages.
You can likely not just merge this since I made the changes in the .py file not the .ipynb file. But manually adding the changes to the notebook should be fairly painless.