Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure description logic #3

Merged
merged 1 commit into from
Dec 9, 2016
Merged

Restructure description logic #3

merged 1 commit into from
Dec 9, 2016

Conversation

lokal-profil
Copy link
Member

In the previous version you would always get a second set of
descriptions if you have "Beskrivning" (as can be seen in the
.json file. The current solution separate the OK_to_upload and
lacking_decription checks from the decription generation.

I also changed the order of "Ort, foto" and "Händelse" in the
decription.

In the previous version you would always get a second set of
descriptions if you have "Beskrivning" (as can be seen in the
.json file. The current solution separate the OK_to_upload and
lacking_decription checks from the decription generation.

I also changed the order of "Ort, foto" and "Händelse" in the
decription.
@mattiasostmar mattiasostmar merged commit 3525a83 into Wikimedia-Sverige:master Dec 9, 2016
@mattiasostmar
Copy link
Collaborator

Ah, now I understand the problem better. Yes it worked:

Example file 0307.a.0001:
was:
|description = {{sv|Teotihuacans monumentalbyggnader utlagda på karta över Stockholm.
''Nyckelord:'' karta, Stockholm. }}
{{en|Images from the 1932 Sigvald Linné archeological expedition at Teotihuacán, Mexico.}}
|description = {{sv|}}
{{en|Images from the 1932 Sigvald Linné archeological expedition at Teotihuacán, Mexico.}}

is now:
|description = {{sv|Teotihuacans monumentalbyggnader utlagda på karta över Stockholm.
''Nyckelord:'' karta, Stockholm.}}
{{en|Images from the 1932 Sigvald Linné archeological expedition at Teotihuacán, Mexico.}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants