Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Escaping $ in *nix platforms #40

Closed
lekkas opened this issue Aug 3, 2016 · 2 comments
Closed

Escaping $ in *nix platforms #40

lekkas opened this issue Aug 3, 2016 · 2 comments

Comments

@lekkas
Copy link
Contributor

lekkas commented Aug 3, 2016

I noticed that $ is not escaped as it probably should in Linux/OS X. For instance, this:

Rsync = require('rsync')
var rsync = new Rsync()
  .flags('az')
  .source('/source')
  .destination('server:/destination$test')
  .command()

will yield

"rsync -az /source server:/destination$test"

So when the rsync command is run, $test will be interpreted as an environment variable.

@mattijs
Copy link
Owner

mattijs commented Sep 11, 2016

I wanted to keep this as a feature but I'm starting to think that it doesn't make sense. Would you be willing to open a PR for this?

@lekkas
Copy link
Contributor Author

lekkas commented Sep 11, 2016

Sure.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants