Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small issue on installing the plug #5

Open
IlanVivanco opened this issue Jan 16, 2018 · 2 comments
Open

Small issue on installing the plug #5

IlanVivanco opened this issue Jan 16, 2018 · 2 comments

Comments

@IlanVivanco
Copy link

IlanVivanco commented Jan 16, 2018

Hi @mattkeys, first of all, great plug! It was exactly what I needed.

Just a small issue I noticed, when first installing the plug.
I had some JS errors in the console not allowing to load the values properly: value_values was undefined and it couldn't get the id prop.
image. I'm sorry I couldn't get the console error screen, but I can't replicate it again now. I debugged it and found that in /includes/field_group_conditional_taxonomy.js:72, $( '.conditional-rule-value', $rule ); got no results.

I solved it simply removing the taxonomy field (created prior installation) and adding it again.
WP version: WordPress 4.8.4
ACF Pro version: Version 5.6.7

Hope this helps you to find the origin of the problem.

Tnx

@mattkeys
Copy link
Owner

Ah yea I probably need to add some error checking there to make sure that value_values (what a bad name ..) is set before I try to access its id and text. In my test environment I wasn't working with any existing fields I suppose.

@IlanVivanco
Copy link
Author

Sounds reasonable ;)

The solution is very simple in case someone faces the same issue anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants