Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CalendarDayViewComponent]-the output type is missing 'sourceEvent' property #1274

Closed
wildMio opened this issue Jun 11, 2020 · 2 comments
Closed

Comments

@wildMio
Copy link

wildMio commented Jun 11, 2020

Describe the bug

eventClicked & hourSegmentClicked output type are missing 'sourceEvent' property.

original:

  @Output() eventClicked = new EventEmitter<{
    event: CalendarEvent;
  }>();

  /**
   * Called when an hour segment is clicked
   */
  @Output() hourSegmentClicked = new EventEmitter<{
    date: Date;
  }>();

expected:

  @Output() eventClicked = new EventEmitter<{
    event: CalendarEvent;
    sourceEvent: MouseEvent | any;
  }>();

  /**
   * Called when an hour segment is clicked
   */
  @Output() hourSegmentClicked = new EventEmitter<{
    date: Date;
    sourceEvent: MouseEvent;
  }>();

Minimal reproduction of the problem with instructions

Screenshots

Versions

  • @angular/core: 9.1.9
  • angular-calendar: 0.28.16`
@matts-bot
Copy link

matts-bot bot commented Jun 11, 2020

Thanks so much for opening an issue! If you'd like me to give priority to answering your issue or would just like to support this project, then please consider sponsoring me

@mattlewis92
Copy link
Owner

Thanks for letting me know! I just released 0.28.19 with a fix 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants