feat(config): support istanbul-api instrumentation configuration #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With the new istanbul-api our symlinked monorepo packages are no longer being added to our coverage reports. Although istanbul-api has now been deprecated so I was tempted to try and move to the newer istanbul packages. This change was quicker and easier though. I could try to upgrade the dependencies in another PR if that's something that would be wanted? |
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
======================================
Coverage 97.7% 97.7%
======================================
Files 2 2
Lines 131 131
======================================
Hits 128 128
Misses 3 3
Continue to review full report at Codecov.
|
mattlewis92
requested changes
Jul 20, 2019
Add a configuration option to provide istanbul-api instrumentation configuration
briandipalma
force-pushed
the
add-instrumentation-configuration
branch
from
0ae2e67
to
401aee6
Compare
|
Requested changes all done. Thanks for taking a look at the PR. |
mattlewis92
approved these changes
Jul 24, 2019
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configuration option to provide istanbul-api instrumentation configuration