Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streaming skeleton occasionally crashloopbackoffs #7

Open
mattmoor opened this issue Mar 10, 2019 · 2 comments
Open

streaming skeleton occasionally crashloopbackoffs #7

mattmoor opened this issue Mar 10, 2019 · 2 comments

Comments

@mattmoor
Copy link
Owner

Use the sample @ with-unary with the client running in a watch.

There's intermittently an error sending on a closed errCh.

@mattmoor
Copy link
Owner Author

$ kubectl logs stream-sampleservice-99xx9-deployment-579669958d-lrgxm user-container
panic: send on closed channel

goroutine 55 [running]:
main.(*server).Stream.func1(0xc0002802a0, 0x993200, 0xc0002682b0, 0xc000280360)
        /usr/local/google/home/mattmoor/go/src/github.com/mattmoor/korpc-sample/gen/entrypoint/sampleservice/stream/main.go:39 +0xe2
created by main.(*server).Stream
        /usr/local/google/home/mattmoor/go/src/github.com/mattmoor/korpc-sample/gen/entrypoint/sampleservice/stream/main.go:31 +0xc8

@mattmoor
Copy link
Owner Author

Using a sync.WaitGroup that closes errCh after wg.Wait() in a fourth go routine seems to work, but I think this logic should be reworked to consider semi-streamed methods too (this is just the most complicated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant