Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go get'ing go-encoding fails due to encoding/charmap's changes #1

Closed
astj opened this issue Mar 31, 2017 · 2 comments
Closed

go get'ing go-encoding fails due to encoding/charmap's changes #1

astj opened this issue Mar 31, 2017 · 2 comments

Comments

@astj
Copy link

astj commented Mar 31, 2017

go get github.com/mattn/go-encoding fails with following message:

$ docker run --rm -it --entrypoint=/bin/bash golang:1.8
root@705268b8f056:/go# go get github.com/mattn/go-encoding
# github.com/mattn/go-encoding
src/github.com/mattn/go-encoding/encoding.go:17: cannot use &charmap.CodePage437 (type **charmap.Charmap) as type *encoding.Encoding in map value:
	*encoding.Encoding is pointer to interface, not interface
src/github.com/mattn/go-encoding/encoding.go:18: cannot use &charmap.CodePage850 (type **charmap.Charmap) as type *encoding.Encoding in map value:
	*encoding.Encoding is pointer to interface, not interface
src/github.com/mattn/go-encoding/encoding.go:19: cannot use &charmap.CodePage852 (type **charmap.Charmap) as type *encoding.Encoding in map value:
	*encoding.Encoding is pointer to interface, not interface
src/github.com/mattn/go-encoding/encoding.go:20: cannot use &charmap.CodePage855 (type **charmap.Charmap) as type *encoding.Encoding in map value:
	*encoding.Encoding is pointer to interface, not interface
src/github.com/mattn/go-encoding/encoding.go:21: cannot use &charmap.CodePage858 (type **charmap.Charmap) as type *encoding.Encoding in map value:
	*encoding.Encoding is pointer to interface, not interface
src/github.com/mattn/go-encoding/encoding.go:22: cannot use &charmap.CodePage860 (type **charmap.Charmap) as type *encoding.Encoding in map value:
	*encoding.Encoding is pointer to interface, not interface
src/github.com/mattn/go-encoding/encoding.go:23: cannot use &charmap.CodePage862 (type **charmap.Charmap) as type *encoding.Encoding in map value:
	*encoding.Encoding is pointer to interface, not interface
src/github.com/mattn/go-encoding/encoding.go:24: cannot use &charmap.CodePage863 (type **charmap.Charmap) as type *encoding.Encoding in map value:
	*encoding.Encoding is pointer to interface, not interface
src/github.com/mattn/go-encoding/encoding.go:25: cannot use &charmap.CodePage865 (type **charmap.Charmap) as type *encoding.Encoding in map value:
	*encoding.Encoding is pointer to interface, not interface
src/github.com/mattn/go-encoding/encoding.go:26: cannot use &charmap.CodePage866 (type **charmap.Charmap) as type *encoding.Encoding in map value:
	*encoding.Encoding is pointer to interface, not interface
src/github.com/mattn/go-encoding/encoding.go:26: too many errors

Maybe this is due to recent go/text 's change ( golang/text@65f4f82 golang/go#19584 )?

@mattn
Copy link
Owner

mattn commented Mar 31, 2017

Okay, I'll look into it.

@astj
Copy link
Author

astj commented Mar 31, 2017

I confirmed this fixed. Thank you!!

$ docker run --rm -it --entrypoint=/bin/bash golang:1.8
root@a4d37de2fa0d:/go# go get github.com/mattn/go-encoding
root@a4d37de2fa0d:/go#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants