Upgrade plugin for usage with 0.4.x #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josegonzalez
force-pushed
the
master
branch
from
f29d97c
to
5f0d4d7
Compare
|
Hmm, going to redo this pr bit by bit... |
josegonzalez
force-pushed
the
master
branch
from
5f0d4d7
to
506bbab
Compare
|
Heh, I think it broke because I was sending messages to stderr (yayaya) as opposed to stdout. We have common helpers now to do that sort of stuff. |
|
Thanks for the PR! I'll test this once I get around to upgrading our server to 0.4.x. In the meantime can you please squash these commits into a single one? |
matt-oakes
pushed a commit
that referenced
this pull request
Oct 6, 2015
Upgrade plugin for usage with 0.4.x
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.