Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input order of angles of drawEllipse3d #31

Open
oqilipo opened this issue Aug 28, 2017 · 1 comment
Open

input order of angles of drawEllipse3d #31

oqilipo opened this issue Aug 28, 2017 · 1 comment

Comments

@oqilipo
Copy link
Contributor

oqilipo commented Aug 28, 2017

Hi David

For me it seems a little bit inconsistent (and it was quite confusing ;-) ) that drawEllipse3d uses the order:
THETA PHI PSI as input
while other functions like rotation3dToEulerAngles, drawEllipsoid, drawCuboid use:
PHI THETA PSI

Wouldn't it make more sense to use PHI THETA PSI as standard in all functions?
http://mathworld.wolfram.com/EulerAngles.html

Kind regards
oqilipo

@dlegland
Copy link
Member

Hi oqilipo,

Yes, I use two conventions for 3D angles, and I agree this may be confusing... Some explanations:

  • for "solid" objects, it is usually more natural to consider rotation of the main axis axis, and then to use "yaw-pitch-roll" analogy. Hence the Phi-Theta-Psi convention, corresponding to XYZ Euler angles.
  • for flat objects (3D ellipses or discs), I found it more natural to consider rotation of the normal angle, and the rotation around the normal angle. This convention is used also in astronomy. So the rotation angles are different, and are more related to the ZYZ Euler angle convention.

I do not know if there is an "ideal" solution. It seems that many different conventions are used, making it difficult to make different packages work together. I finally choose two different systems, by considering that each one was adapted to a given case, and that they were easy to represent (at least for me...).

regards,
David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants