Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineDataset Properties #13

Closed
46692 opened this issue Mar 1, 2018 · 1 comment
Closed

LineDataset Properties #13

46692 opened this issue Mar 1, 2018 · 1 comment
Assignees
Labels

Comments

@46692
Copy link

46692 commented Mar 1, 2018

The 'Fill' and 'SteppedLine' properties of a LineDataset should be string instead of bool? to allow values such as 'end', '+2' etc.
These pages offer some examples of what I mean:
http://www.chartjs.org/samples/latest/charts/area/line-datasets.html
http://www.chartjs.org/samples/latest/charts/line/stepped.html

@mattosaurus
Copy link
Owner

Hi @Oelkrug, It looks like these fields can be either bool, int or string.
https://github.com/chartjs/Chart.js/blob/master/docs/charts/area.md
I've updated the code to accept a string input and if the value of the field is a boolean or integer than that will be output (without quotes), otherwise a standard quoted string will be output.

These changes have been published in v1.2.2 of the package.

@mattosaurus mattosaurus self-assigned this Mar 3, 2018
@mattosaurus mattosaurus added the bug label Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants