This repository has been archived by the owner on Jul 6, 2019. It is now read-only.
Avoid creating an animated image for 1-frame GIFs #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
pushed a commit
that referenced
this pull request
Aug 13, 2014
Signed-off-by: Mattt Thompson <m@mattt.me>
|
Thanks for your PR, @rsanchezsaez. I applied a refactored version of the code in 0aad679, which is credited to you. I'll cut a new release once I'm finished going through the rest of the open issues. |
|
Happy to help! :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading GIFs with just 1 frame the
constructor was being used, and
UIImage'simagesproperty was returning an array with only one element.I think that when loading GIFs with just 1 frame they should load as regular non-animated images. I modified the code so that's the case.
Also added some test logs to check the
imagesproperty values for 1-framed GIF and for a PNG file.