Added optional timeout parameter to the job decorator. #7
Conversation
…fect past implementations that use flask-rq. Added an example and entry to the readme accordingly.
|
+1 |
| if timeout is None: | ||
| return q.enqueue(fn, *args, **kwargs) | ||
| else: | ||
| return q.enqueue_call(func=fn, args=args, kwargs=kwargs, timeout=timeout) |
There was a problem hiding this comment.
Should be using the default_timeout argument name since RQ 0.3.0 - http://python-rq.org/docs/results/
There was a problem hiding this comment.
enqueue also has a timeout param so I don't think this if statement is needed.
There was a problem hiding this comment.
I need this change too. I was adding it myself in my code base.
I see the PR is dead due to a connection failure https://travis-ci.org/mattupstate/flask-rq/jobs/29826186#L88
This is very useful. Seems its been a while, may we please resurrect the thread?
Please let me know if this needs help.
|
Bump. This is very useful, any progress on this? @mschmo I don't think so. |
|
@rkubik I reread the documentation in the link I posted and I agree with you. Not sure what I was thinking at the time, but that was 9 months ago so who knows. |
|
Would love to see this land on master -- anything I can do to help? |
Added support for an optional timeout parameter to the job decorator so one may override the redis default of 180 seconds. Does not affect past implementations that use flask-rq. Added an example and entry to the readme accordingly.