This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
add SECURITY_POST_LOGIN_ALLOW_REDIRECT_DOMAIN option #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @mattupstate |
jirikuncar
reviewed
Oct 31, 2017
| @@ -314,6 +314,11 @@ Miscellaneous | |||
| ``SECURITY_DATETIME_FACTORY`` Specifies the default datetime | |||
| factory. Defaults to | |||
| ``datetime.datetime.utcnow``. | |||
| ``POST_LOGIN_ALLOW_REDIRECT_DOMAIN`` Specifies domain allowed to be | |||
There was a problem hiding this comment.
Please use SECURITY_ prefix.
jirikuncar
reviewed
Oct 31, 2017
| ``POST_LOGIN_ALLOW_REDIRECT_DOMAIN`` Specifies domain allowed to be | ||
| redirected to after login. You can | ||
| use wildcard patterns like | ||
| ``*.doumail.com``. Defaults to the |
There was a problem hiding this comment.
*.doumail.com -> *.example.com to be clear that it's an example.
jirikuncar
suggested changes
Oct 31, 2017
|
sorry it has been too long, can't remember the details here |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this: after login from
www.domain.com, the user should be redirected toen.domain.com, which is not allowed by Flask-Security currently.so a new option
SECURITY_POST_LOGIN_ALLOW_REDIRECT_DOMAINis introduced, in the above situation, one could setSECURITY_POST_LOGIN_ALLOW_REDIRECT_DOMAIN = '*.domain.com'to allow such redirection.