Fixing the different possibilities for the register form.

[sdiepend]

Fix for issues
#601
#580

Adds a new flag: SECURITY_RETYPABLE which allows you to specify
if users have to confirm(retype) their password or not when registering.

Now you have four different combinations of possible register forms.

CONFIRMABLE: False, RETYPABLE: False => RegisterForm
CONFIRMABLE: True, RETYPABLE: False => ConfirmRegisterForm
CONFIRMABLE: False, RETYPABLE: True => RetypeRegisterForm
CONFIRMABLE: True, RETYPABLE: True => ConfirmRetypeRegisterForm

Only when using the API it will default to ConfirmRegisterForm as before.

[jirikuncar]

This functionality can be done already via configurable forms (see #601 (comment)). Also I see the different forms for regular and API confusing.

I would propose that we can split the forms so one can easily choose one with password confirmation or without it. WDYT?

[sdiepend]

Yes, split them, but we should add a flag for this. That's the SECURITY_RETYPABLE I had chosen. Because SECURITY_CONFIRMABLE is used for account/email confirmation.

We probably don't need a different form for the account/email confirmation as has no influence on the fields of the form itself.

[jirikuncar]

The functionality added by SECURITY_RETYPABLE flag can be configured only via SECURITY_ REGISTER_FORM and SECURITY_CONFIRM_REGISTER_FORM, hence I am not a big fan of adding it.

[sdiepend]

@jirikuncar I can't find the flags/config you are describing
https://github.com/mattupstate/flask-security/search?utf8=%E2%9C%93&q=SECURITY_REGISTER_FORM&type=
https://github.com/mattupstate/flask-security/search?q=SECURITY_CONFIRM_REGISTER_FORM&type=Code&utf8=%E2%9C%93

[jirikuncar]

Check:

• https://github.com/mattupstate/flask-security/blob/develop/flask_security/core.py#L343-L345
• https://github.com/mattupstate/flask-security/blob/develop/tests/test_misc.py#L256-L276

We need to document it better O:-)

[jirikuncar]

@sdiepend feel free to re-open the PR if you are not happy with the proposed solution.