This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
Tests passing! #26
Merged
Tests passing! #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for google users who haven't signed up to google plus
I'm assuming at the time the Flask-Social documentation was written, Flask-MongoEngine and Facebook-SDK weren't on PyPI yet. I can install from these locations without any issues, so let's simplify these docs.
With this, you can be explicit about what settings are expected
in your root settings.py file. SOCIAL_FACEBOOK can be None, for
example, and overridden in another file or in the environment.
Here's my personal setup:
SOCIAL_TWITTER = {
'consumer_key': os.environ.get('TWITTER_CONSUMER_KEY'),
'consumer_secret': os.environ.get('TWITTER_CONSUMER_SECRET'),
} if os.environ.get('TWITTER_CONSUMER_KEY') else None
It would be ideal if 'consumer_key' could allow None, but I didn't want
to break the OAuth mechanism in this commit, so this is good enough.
Update installation section to always use PyPI
Allow SOCIAL_<PROVIDER> settings to be None
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the current
developbranch, rebased against master from this PR.