Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

Fix google #32

Closed
wants to merge 2 commits into from
Closed

Fix google #32

wants to merge 2 commits into from

Conversation

pib
Copy link
Contributor

@pib pib commented Feb 17, 2014

The "name" field returned by the google profile is an object of the format

"name": {
  "familyName": "Bonser",
  "givenName": "Paul"
 }

This fix turns it into a string instead, and also uses the displayName attribute of the response since it is there and perhaps might be different.

Also, there's a change to only use the provider_id and provider_user_id when doing a lookup for existing connections.

@pib
Copy link
Contributor Author

pib commented Feb 17, 2014

Wait, I see this has perhaps already been fixed in the latest develop...

@pib pib closed this Feb 17, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant