You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test for coverage for this change. Test passes for SQLAlchemy app, but not for MongoDB or Peewee apps. The after_this_request(_commit) doesn't seem to take for those two, and I'm not sure exactly how to add the updated connection object to the abstracted "session" (or if that even makes sense in this abstraction).
Also 2, plan to add a /reauth (or equivalent) route, which would log the user out, then log them back in through the account that needs reauting, resulting in a reauth, unless anyone sees a cleaner way to do that.
I've added the get_token_pair_from_response method to all providers, added the /reconnect/<provider_id> route, and written a test to cover the new route. The mongo and peewee tests are still failing, (now on both tests).
Doh. I needed to add _datastore.put(connection) after it was updated. I'm actually confused as to why the SQLAlchemyDatastore tests passed without that, particularly because I just tested it in the wild and it didn't work. WIth that change, all tests are passing. Testing in the wild currently.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test for coverage for this change. Test passes for SQLAlchemy app, but not for MongoDB or Peewee apps. The
after_this_request(_commit)
doesn't seem to take for those two, and I'm not sure exactly how to add the updatedconnection
object to the abstracted "session" (or if that even makes sense in this abstraction).