Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gravity Sync #28

Closed
mentalsoup opened this issue Sep 14, 2022 · 6 comments · Fixed by #50
Closed

Gravity Sync #28

mentalsoup opened this issue Sep 14, 2022 · 6 comments · Fixed by #50
Assignees

Comments

@mentalsoup
Copy link

What feature would you like added?

Based upon a fresh instance of pihole on both docker tenants.

Feature

Once the teleport completes successfully, then trigger gravity sync on the secondary pihole.

Observations

I noticed that after a successful sync between master and secondary pihole tenants, the adlists on the secondary did not appear to be downloaded.

https://raw.githubusercontent.com/StevenBlack/hosts/master/hosts

Health status of this list: List was not downloaded so far
This list was added to Pi-hole 2 hours ago (2022-09-14 19:34:54)
Database entry was last modified 8 minutes ago (2022-09-14 21:51:22)
The list contents were last updated N/A
Number of domains on this list: N/A
Number of invalid domains on this list: N/A
Database ID of this list: 1

Version

1.1.1 (latest)

Log output

No response

@mattwebbio
Copy link
Owner

Ah, great catch! Thanks for this. I was hoping the teleporter would automatically take care of this but I guess not. I'll look into this further and see what's involved in making sure this gets run

@mentalsoup
Copy link
Author

I will test further as I have been hit by the permission issues in docker pihole, took a while to figure that one out. This manifested in failures to write to the adlist on the dB. Setting env WEB_UID to the container's pihole user resolved it. For now at least.
So this issue might be false, I will try to confirm.

@mentalsoup
Copy link
Author

The issue stills stands for me. I added a new item to the adlist on the primary.
Restarted orbital-sync.
Waited for the sync to complete.
The new item appeared in the adlist on the secondary pihole, but the status of all items shows as above in my original post.

Manually triggering an update of gravity refreshes without an issue.

@mattwebbio
Copy link
Owner

@mentalsoup I've published a beta version of the container that should resolve this. The image has been published as: mattwebbio/orbital-sync:1.2.2-beta.0

If at some point you have the time to try it, I'd love to hear if it works for you 😄

@mentalsoup
Copy link
Author

Thanks @mattwebbio, great work. I have updated to mattwebbio/orbital-sync:1.2.2-beta.0 and the sync has completed successfully on both targets. No errors, but this has spawned a new idea, I will raise a new feature request.
I am going to switch back to the latest image and await the update from there.

@mattwebbio
Copy link
Owner

Perfect! I've gone ahead and released version 1.3 of the container with this change 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants