Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Search YouTube" results has duplicates #85

Closed
bernard01 opened this issue Aug 2, 2021 · 2 comments
Closed

"Search YouTube" results has duplicates #85

bernard01 opened this issue Aug 2, 2021 · 2 comments
Labels
bug Something's broken or doesn't seem right resolved A fix has been committed to develop but is not released yet.

Comments

@bernard01
Copy link

With the number of results growing, say thousand results, a list copied to the clipboard contains many duplicates. With this size, typically 3 times as many results as the number of real hits. I don't know whether this is caused by the YouTube API of by YCS. Since YCS pagination works by combining pages into a larger result, I guess YCS could check for duplicates and sort again after reading the results from a set. The copy function is really great because I can paste the result into a spreadsheet and build my own SQL from the result and eliminate results that are already in the database.

@mattwright324 mattwright324 added the bug Something's broken or doesn't seem right label Aug 2, 2021
@mattwright324
Copy link
Owner

mattwright324 commented Aug 2, 2021

This appears to be a limitation on YouTube's side that I did not account for, at about 10-13 pages in the API nextPageToken reverts back to blank which is the first page. So you can only get ~500-650 results. Since the app doesn't stop you and you get into the 1500 range you would then be seeing the duplicate entries since it looped back to the first API page 2-3 times.

I can disable the next page button when it returns blank and would need to add a message indicating why.

@mattwright324
Copy link
Owner

I have this fixed in commit 3af47e9 and will be out in the next release.

When it reaches the last page of results that the API is willing to provide the button will display as "Out of pages" and the total will be replaced with the total of displayed results to avoid confusion.

image
image

@mattwright324 mattwright324 added the resolved A fix has been committed to develop but is not released yet. label Aug 2, 2021
@mattwright324 mattwright324 mentioned this issue Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's broken or doesn't seem right resolved A fix has been committed to develop but is not released yet.
Projects
None yet
Development

No branches or pull requests

2 participants