Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] shadowItemUpdateFix won't update correctly #2

Closed
linusvdv opened this issue Mar 4, 2022 · 4 comments
Closed

[Bug] shadowItemUpdateFix won't update correctly #2

linusvdv opened this issue Mar 4, 2022 · 4 comments
Assignees
Labels
bug Something isn't working incompatibility the mod is incompatibile with some other mod

Comments

@linusvdv
Copy link

linusvdv commented Mar 4, 2022

BlockEntities won't update in all Cases.
Bug found with two shadow items set in a hopper (chest ...). Only on one item (always the latest you put into the Storage) will be updated.

shadow-item-update-bug.mp4

.

@mattymatty97
Copy link
Owner

are you using lithium while testing?

@linusvdv
Copy link
Author

linusvdv commented Mar 5, 2022

Yes, without it it functions. Is there a way to run nevertheless lithium?

@mattymatty97
Copy link
Owner

yes, in the config folder there is a file called "lithium.properties"
in it you can disable "hopper optimizations" that are the cause of the incompatibility.

like this:

# This is the configuration file for Lithium.
#
# You can find information on editing this file and all the available options here:
# https://github.com/jellysquid3/lithium-fabric/wiki/Configuration-File
#
# By default, this file will be empty except for this notice.
mixin.block.hopper = false

@mattymatty97 mattymatty97 self-assigned this Mar 5, 2022
@mattymatty97 mattymatty97 added bug Something isn't working incompatibility the mod is incompatibile with some other mod labels Mar 5, 2022
@linusvdv linusvdv closed this as completed Mar 6, 2022
@wendavid552
Copy link

wendavid552 commented Mar 12, 2023

In fact lithium of version 1.18+ has fixed the problem, you could cherry-pick the commit 33f485 and a82bc4 from latest branches to the 1.17- branch(To be more specific, 1.17 only as the hopper optimization is added in 1.17). It works well with carpet-shadow.

Perhaps carpet-shadow could also give a fix for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working incompatibility the mod is incompatibile with some other mod
Projects
None yet
Development

No branches or pull requests

3 participants