Critical hits are not being calculated for melee attacks

[jlcvp]

#235 doesn't completely fixed the critical hit calculations. There's a bug where normal melee attacks are not triggering critical damage. I suspect the error is the damage type check on Combat::doCombat methods before calling Player::doCriticalDamage

[joseluis2g]

what you mean with normal melee attacks?

[jlcvp]

@joseluis2g knight auto-attack hit (without elemental damage on weapon)

[joseluis2g]

yeah I tested it, and not its not the combat type, I did some modifications adding the critical function to combatheal and now when you use runes it only hit a few creatures.

[Schiffers]

hello folks, I do something and now the hits is calculated:
in combat.cpp
void Combat::CombatHealthFunc(Creature* caster, Creature* target, const CombatParams& params, void* data)
above
Player* targetPlayer = target->getPlayer();
add

Player* casterPlayer = caster->getPlayer();
if (casterPlayer) {
	casterPlayer->doCriticalDamage(damage);
}

but with this cause crash here, someone can test it?

[joseluis2g]

before this

if (g_game.combatChangeHealth(caster, target, damage)) {

add this

if (caster && caster->getPlayer()) {
		caster->getPlayer()->doCriticalDamage(damage);
}

[Schiffers]

I'll compile it now, did you tested?
I'm almost sure that will crash here, always the caster is null, using the mvs debbuger show something like it
caster = 0x0000000000 as it is invalid, don't find the variable

[joseluis2g]

you call caster and you do not check if it exist

if (casterPlayer) {

should be

if (caster && casterPlayer) {

:)

edit:
actually it should be like this

if (caster) {
	Player* casterPlayer = caster->getPlayer();
	if (casterPlayer) {
		casterPlayer->doCriticalDamage(damage);
	}
}

[Schiffers]

@joseluis2g sure, I'm compile, could you add me on skype to we trade some ideas?

[joseluis2g]

im at discord, I dont know why but my skype isnt working :/
im discord id is Streamside#8347