Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support blurhash placeholder #77

Closed
srmullen opened this issue Oct 19, 2020 · 3 comments
Closed

Support blurhash placeholder #77

srmullen opened this issue Oct 19, 2020 · 3 comments

Comments

@srmullen
Copy link
Contributor

First off, thank you for this library! It's been very helpful.

It would be nice to support blurhash as a placeholder. For inlining, they are smaller than the base64 encoding, and I think they look a bit nicer than the currently offered blur option.

I have a pull request just about ready for this if interested. Let me know your thoughts. Thanks!

@matyunya
Copy link
Owner

If that's the case then we should probably replace current blur with it?

@srmullen
Copy link
Contributor Author

I think that might be reasonable, but I didn't want to change how things work for those currently using the blur option. Blurhash requires a canvas to render, so maybe it would be better to let users opt into it.

@matyunya
Copy link
Owner

Canvas would require more CPU to render so that sounds right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants