Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature to include method reference in RFC metric #56

Conversation

maykon-oliveira
Copy link
Contributor

  • Now the method reference calls are counted in the RFC metrics

  • I updated the pom to use Junit 5

This new version has a readable api and some useful things, such as @DisplayName, to declare more friendly names for test cases.

All old tests are ok with the new version of Junit, I had to change the package of some annotations, but everything works.

@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #56 into master will decrease coverage by 22.75%.
The diff coverage is 96.55%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #56       +/-   ##
=============================================
- Coverage     73.85%   51.10%   -22.76%     
+ Complexity      888      542      -346     
=============================================
  Files            40       40               
  Lines          2127     2131        +4     
  Branches        253      252        -1     
=============================================
- Hits           1571     1089      -482     
- Misses          412      905      +493     
+ Partials        144      137        -7     
Impacted Files Coverage Δ Complexity Δ
.../java/com/github/mauricioaniche/ck/metric/RFC.java 96.66% <96.55%> (+0.51%) 12.00 <11.00> (+1.00)
...uricioaniche/ck/metric/NumberOfMaxNestedBlock.java 39.56% <0.00%> (-53.85%) 13.00% <0.00%> (-18.00%)
.../java/com/github/mauricioaniche/ck/metric/WMC.java 53.48% <0.00%> (-45.35%) 17.00% <0.00%> (-18.00%)
...github/mauricioaniche/ck/metric/NumberOfLoops.java 57.14% <0.00%> (-42.86%) 4.00% <0.00%> (-3.00%)
...ithub/mauricioaniche/ck/metric/NumberOfFields.java 61.29% <0.00%> (-38.71%) 3.00% <0.00%> (-6.00%)
.../mauricioaniche/ck/util/SourceCodeLineCounter.java 22.72% <0.00%> (-36.37%) 5.00% <0.00%> (-13.00%)
...n/java/com/github/mauricioaniche/ck/CKVisitor.java 33.77% <0.00%> (-29.44%) 150.00% <0.00%> (-142.00%)
...va/com/github/mauricioaniche/ck/CKClassResult.java 67.36% <0.00%> (-27.09%) 49.00% <0.00%> (-39.00%)
...a/com/github/mauricioaniche/ck/CKMethodResult.java 67.81% <0.00%> (-25.29%) 31.00% <0.00%> (-22.00%)
.../java/com/github/mauricioaniche/ck/metric/CBO.java 46.15% <0.00%> (-25.18%) 29.00% <0.00%> (-18.00%)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7491d8...7173908. Read the comment docs.

@mauricioaniche
Copy link
Owner

Hi, @maykon-oliveira! Thanks for the PR! The way it is now, it's just very hard to review, though :/

I would need you to:

  1. Your IDE replaced tabs to spaces. This means you basically changed all files in the project.
  2. Split the PRs in two. One that moves things to JUnit 5 (thanks for that), and another one that adds the new functionality to RFC. (Note that codecov says that coverage went down significantly, so I imagine some tests are not being run by the coverage tool anymore?)

Cheers!

@maykon-oliveira
Copy link
Contributor Author

Sure, it's better. I will create two pull requests, one with Junit update, and other that adds the new functionality to RFC.

@mauricioaniche
Copy link
Owner

@maykon-oliveira Now, we are ready for this PR, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants