-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitRepository::getCommit seems to ignore git.diffcontext #128
Comments
It looks like in So, after only cursory checking,
|
It indeed seems that there's some repetition. I'll try to understand why it happens and submit a PR -- ofc, if you have time, you can submit the PR yourself! Thanks for spotting it, btw! |
If a fix isn't issued until around mid-April, I'm happy to work on it. But I can't until then :( |
Ok, looks like in If we pass this check, then we turn each Diff into a This is my understanding of what's going on. Any insight as to why? I have the time issue a fix now, but I want to clarify the scope of this fix first (i.e., only setting the context, or refactoring to use only one |
ping @mauricioaniche |
It sticks to the Git default of 3, even though I've set the
git.diffcontext
System property. The private methodgetSystemProperty
successfully finds the value I set, but the diff output remains the same.The text was updated successfully, but these errors were encountered: