Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fine-tuning in package filter #135

Open
4 of 6 tasks
JorderGomes opened this issue Oct 30, 2023 · 0 comments
Open
4 of 6 tasks

fine-tuning in package filter #135

JorderGomes opened this issue Oct 30, 2023 · 0 comments

Comments

@JorderGomes
Copy link

JorderGomes commented Oct 30, 2023

  • src/main/java/org/repodriller/filter/range/LastMonths.java:13: SingularField: Perhaps 'sixMonthsAgo' could be replaced by a local variable.

  • LooseCoupling: Avoid using implementation types like 'LinkedList'; use the interface instead

    src/main/java/org/repodriller/filter/range/BetweenDates.java:25:
    src/main/java/org/repodriller/filter/range/DailyCommits.java:27:
    src/main/java/org/repodriller/filter/range/DailyCommits.java:39:
    src/main/java/org/repodriller/filter/range/LastMonths.java:22:
    src/main/java/org/repodriller/filter/range/MonthlyCommits.java:28:
    src/main/java/org/repodriller/filter/range/MonthlyCommits.java:40:

  • src/main/java/org/repodriller/filter/range/SinceCommit.java:23: LooeCoupling: Avoid using implementation types like 'LinkedList'; use the interface instead

  • src/main/java/org/repodriller/filter/range/DailyCommits.java:16:UnusedPrivateField: Avoid unused private fields such as 'log'.

  • src/main/java/org/repodriller/filter/range/DailyCommits.java:45:UselessParentheses: Useless parentheses.

  • src/main/java/org/repodriller/filter/range/MonthlyCommits.java:46: UselessParentheses: Useless parentheses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant