Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if it's a merge, provide both parents of the commit #51

Open
mauricioaniche opened this issue Nov 3, 2016 · 6 comments
Open

if it's a merge, provide both parents of the commit #51

mauricioaniche opened this issue Nov 3, 2016 · 6 comments

Comments

@mauricioaniche
Copy link
Owner

No description provided.

@davisjam
Copy link
Contributor

Working on this as part of #100

@ttben
Copy link
Contributor

ttben commented Dec 16, 2017

Any news about this feature? :)

@mauricioaniche
Copy link
Owner Author

Not from me. Do you wanna work on it, @ttben ? Let me know and we can discuss the implementation!

@ttben
Copy link
Contributor

ttben commented Dec 17, 2017

I can't implement it for now, as I rush 2 papers..
But we can always discuss :) This way, if someone else has time, it will be quicker to implement it!

Adding this feature should:

  • not break any existing code using RepoDriller,
  • be seamless for new users,
  • provide "left" and "right" parent.

Problem: if one wants to analyse every merge commits, even with left and right fields, she has no idea the branches of left and right.
For now, left and right would be String ; but I think Commit instances would be better (see #112) as it embed every usefull information.

Adding a subclass MergeCommit to Commit class will match this constraints and fill the required feature.
I am clearly a newbie in this project as I just discovered it few days ago, don't hesitate to tell me if I am talking non sense!..

@mauricioaniche
Copy link
Owner Author

Really clear. I'll try to tackle this issue soon!

@ttben
Copy link
Contributor

ttben commented Dec 17, 2017

Thanks :)
I think it will be a useful information!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants